Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): shared wallet creation uses currently selected environment #1483

Merged

Conversation

mchappell
Copy link
Collaborator

@mchappell mchappell commented Oct 24, 2024

Checklist


Proposed solution

Use the existing wallet data to select the chain, not a hardcoded value

@mchappell mchappell requested a review from a team as a code owner October 24, 2024 15:44
Copy link

sonarcloud bot commented Oct 24, 2024

@pczeglik-iohk
Copy link
Contributor

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 0d3a4616

passed failed skipped flaky total result
Total 32 0 4 0 36

Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mchappell

@mchappell mchappell merged commit e628f2e into main Oct 25, 2024
29 checks passed
@mchappell mchappell deleted the fix/lw-11766-shared-wallet-respects-current-environment branch October 25, 2024 12:14
mchappell added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants